Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Don't reset the filterText when refreshing the library #1218

Merged
merged 1 commit into from Apr 19, 2022
Merged

[FIX] Don't reset the filterText when refreshing the library #1218

merged 1 commit into from Apr 19, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 17, 2022

This PR fixes #1216 by not resetting the value of filterText in the state when refreshing the library.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 17, 2022
flavioislima
flavioislima approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flavioislima flavioislima changed the title Don't reset the filterText when refreshing the library [FIX] Don't reset the filterText when refreshing the library Apr 19, 2022
@flavioislima flavioislima merged commit d6d20c3 into main Apr 19, 2022
@flavioislima flavioislima deleted the fixes/preserve-filter-on-refresh branch April 19, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates in installed games refreshes the library ignoring search bar
2 participants
@arielj @flavioislima