Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order games by status #1221

Merged
merged 3 commits into from Apr 22, 2022
Merged

Order games by status #1221

merged 3 commits into from Apr 22, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 18, 2022

This PR changes the order of the games in the library to display installed games first, then games that are being installed, and then games that are not installed nor installing.

This also removes the selector of All / Ready / Not Ready / Downloading to simplify the UI.

Closes #977
Closes #878


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 18, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
one thing though: we need to set the filter to all now otherwise if someone upgrade Heroic and has a filter on uninstalled or another one, it will hide the games. this happened to me while testing.
Ideally, just remove the filter part on GlobalState so it won't update the library based on that.

@arielj
Copy link
Collaborator Author

arielj commented Apr 21, 2022

Looks good! one thing though: we need to set the filter to all now otherwise if someone upgrade Heroic and has a filter on uninstalled or another one, it will hide the games. this happened to me while testing. Ideally, just remove the filter part on GlobalState so it won't update the library based on that.

thanks for the test and finding that, I'll update the PR later!

@arielj
Copy link
Collaborator Author

arielj commented Apr 21, 2022

@flavioislima PR is updated!

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :D

@flavioislima flavioislima merged commit 7d87173 into main Apr 22, 2022
@flavioislima flavioislima deleted the feature/order-games-by-status branch April 22, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Show installed games first Make installing games appear at the top
2 participants