Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GOG setup again + don't skip Wineboot for Proton #1352

Merged
merged 3 commits into from
May 21, 2022

Conversation

CommandMC
Copy link
Collaborator

GOG Setup instructions were not ran due to a missing await
I've also reverted the changes about not running Wineboot since otherwise, a Proton prefix would only count as "updated" if the root folder was created by Heroic (so if the user deletes all files inside it, it would still not run the setup instructions)


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested a review from imLinguin May 21, 2022 17:26
Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@CommandMC CommandMC merged commit 4712aa2 into Heroic-Games-Launcher:main May 21, 2022
@CommandMC CommandMC deleted the fix/gog_setup branch May 22, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants