Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Steam App ID variables when using the Runtime on Proton + fixup setting user-defined env vars on native games #1355

Merged
merged 9 commits into from
May 25, 2022

Conversation

CommandMC
Copy link
Collaborator

  • When the Steam Runtime is used for Proton, STEAM_COMPAT_APP_ID and SteamAppId are set to 0. This avoids a ProtonFix crash for GE-Proton
  • User-defined environment variables are now set in setupEnvVars (they were in setupWineEnvVars before). Not sure why I did it that way back then. Because of that, setting these variables on native games works again now.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC
Copy link
Collaborator Author

With the latest commit, Proton's logging feature will now also work. Adding PROTON_LOG=1 to the environment variables will now give you a steam-0.log file in your home directory with the usual Wine log
Maybe we should even override the log folder (PROTON_LOG_DIR env var) and then append the log to our own game log automatically?

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 22, 2022
@CommandMC
Copy link
Collaborator Author

I'd say this is now feature-complete. I have not opted for automatically setting PROTON_LOG=1 since the log can get quite big, and it's not necessary to have it 90% of the time
If the user still needs the log, setting the variable and then navigating to the correct directory (/home/$USER/ normally, /home/$USER/.var/app/com.heroicgameslauncher.hgl/ for Flatpak) is fine

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👍🏽

@flavioislima flavioislima added pr:ready-to-merge This PR is fully ready for merge. and removed pr:ready-for-review Feature-complete, ready for the grind! :P labels May 25, 2022
@CommandMC CommandMC merged commit 2930644 into Heroic-Games-Launcher:main May 25, 2022
@CommandMC CommandMC deleted the steamappid branch May 25, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants