Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Update login with new designs #1376

Conversation

marky-maybe
Copy link
Contributor

Added the new vertical design to the login screen without adding additional components, leaving spacing for additional stores to be added as their own Runners.

Open to making more design changes to more closely fit the design image posted in the reference issue #1153

Screen Shot 2022-05-26 at 3 50 04 PM


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

Thanks for the contribution! 👍🏽
It would be better to stick to the design on that issue because, as it looks on the screenshot, it's not much of a change.
That design was made to support more stores in a optimized space.

@marky-maybe
Copy link
Contributor Author

That design was made to support more stores in a optimized space.

Good point! I'll make some revisions so that it looks closer to the original design

@marky-maybe
Copy link
Contributor Author

Updated screenshot with current changes:
Screen Shot 2022-05-27 at 1 28 20 PM

@flavioislima flavioislima added the pr:testing This PR is in testing, don't merge. label May 28, 2022
@marky-maybe
Copy link
Contributor Author

Changed the styling to include the relevant feedback from the team. It's ready for a bunch of logins to be added as well.

The language selector is mostly left unstyled because it's also connected to the settings page, maybe that should be the next phase?

Screen Shot 2022-05-29 at 10 01 20 AM

@flavioislima flavioislima changed the base branch from main to beta May 31, 2022 15:46
@flavioislima
Copy link
Member

@tildemarky are you still gonna work on this one? I think you have a few conflicts and the design might need some adjustments but it is pretty close. Sorry for forgetting about this one as well.

@biliesilva can you take a look at this latest screenshot and see what needs to be improved for the final design once you have the time?

@biliesilva
Copy link

biliesilva commented Sep 24, 2022

I suggest using these spaces to give more breath to the elements:
image

And use these paddings and gaps here to the language selector:
image

Also the text is better to be oriented to the left.

@marky-maybe
Copy link
Contributor Author

marky-maybe commented Oct 7, 2022

@tildemarky are you still gonna work on this one? I think you have a few conflicts and the design might need some adjustments but it is pretty close. Sorry for forgetting about this one as well.

Hey sorry for the late reply @flavioislima, things got very hectic. I'll push an update with suggested changes within the coming week if nobody else has already stepped forward with this or a different concept.

@flavioislima
Copy link
Member

@tildemarky are you still gonna work on this one? I think you have a few conflicts and the design might need some adjustments but it is pretty close. Sorry for forgetting about this one as well.

Hey sorry for the late reply @flavioislima, things got very hectic. I'll push an update with suggested changes within the coming week if nobody else has already stepped forward with this or a different concept.

no worries.
I believe no one is working on it, feel free to continue :)

@marky-maybe
Copy link
Contributor Author

Still working on conflicts 😅

@marky-maybe marky-maybe force-pushed the feat/update_login_design_multiple branch from 511f89b to 5090b2e Compare October 15, 2022 22:06
@marky-maybe
Copy link
Contributor Author

Screenshot 2022-10-15 at 6 11 29 PM

The current look with the suggested changes! The language selector is mostly left as is, because the design changes would probably require changing the strings to not include the flag so it can be separately styled away from the language label, so that should maybe be its own PR. Not entirely sure.

Let me know if anything else should be adjusted @flavioislima & @biliesilva

@biliesilva
Copy link

biliesilva commented Oct 15, 2022

I have some suggestions below, let me know if you need more examples:

Align CHOOSE APP LANGUAGE and HELP TRANSLATE HEROIC with the box on the left and also give a little space between.
image

@marky-maybe
Copy link
Contributor Author

I have some suggestions below, let me know if you need more examples:

That example helped a lot thank you! Here's what it looks like with those changes

Screenshot 2022-10-15 at 7 16 58 PM

@arielj
Copy link
Collaborator

arielj commented Oct 22, 2022

@tildemarky can you use Epic Alternative Login Method instead of Epic Games External Login for that button? we discussed this on discord and we think it's more clear to the users than External Login.

@arielj
Copy link
Collaborator

arielj commented Oct 22, 2022

The library button looks wrong when logged in:
image

@marky-maybe
Copy link
Contributor Author

Do I also commit the translation files once they're picked up? I've never used i18next before so the procedure is a bit new to me and I'm not sure if I'm the one to do that or if it gets automatically picked up during a later build.

@arielj
Copy link
Collaborator

arielj commented Oct 22, 2022

Do I also commit the translation files once they're picked up? I've never used i18next before so the procedure is a bit new to me and I'm not sure if I'm the one to do that or if it gets automatically picked up during a later build.

Yes, commit the modified files. For more details check https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Translations#how-to-add-new-translatable-strings

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flavioislima flavioislima merged commit d30a5ca into Heroic-Games-Launcher:beta Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:testing This PR is in testing, don't merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants