Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Proper Check if a game is native or not #1387

Merged
merged 6 commits into from
May 28, 2022
Merged

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented May 27, 2022

Fix how we chack isNative on GOG and Legendary.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 27, 2022
@CommandMC
Copy link
Collaborator

The same check is also present for Legendary, could you fix it there as well?

@Nocccer
Copy link
Collaborator

Nocccer commented May 27, 2022

If it is needed for both a util/generic function would be good

@flavioislima
Copy link
Member Author

flavioislima commented May 27, 2022

The same check is also present for Legendary, could you fix it there as well?

I sent the fix but now I will need to test, because last time I checked gameinfo.platform.install was coming undefined from legendary.

@flavioislima
Copy link
Member Author

If it is needed for both a util/generic function would be good

yes, we actually need to think on a better way to deal with the installed platform. there is a lot of code repetition now

@flavioislima
Copy link
Member Author

Ok, things looks fine on macOS as well. Found a small bug with the filter but fixed as well

@flavioislima flavioislima changed the title [Fix] Proper Check if a GOG game is native or not [Fix] Proper Check if a game is native or not May 27, 2022
@flavioislima flavioislima merged commit 099ec05 into main May 28, 2022
@flavioislima flavioislima deleted the fix/native_gog_games branch May 28, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants