Try to fix macOS not launching CX

[CommandMC]

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[flavioislima]

Did you confirm that this is still an issue on macOS?
I will do some tests disabling the shell again to see if it will break.

[CommandMC]

There are a bunch of people in the macOS channel having this issue, so I'd assume that it's still present
Sadly I nuked my macOS VM yesterday by accident, will need some time to get that setup again to test

[flavioislima]

I mean, I am testing here by using the shell on mac again to try to reproduce the first issue we had.
Because after that we had several refactors that might could have fixed the issue.

[flavioislima]

So far, removing the shell: isMac when running the command and this works:

• Install Epic game
• Install GOG game
• play windows games
• play native games
• play windows version of native games
• update a game (could test only on GOGDL since I don't have games to update on epic) is broken, even with latest test version of gogdl. But the command is being called so heroic is doing its part.
• Uninstall a game
• Login on both platforms

So I believe it is 100% safe to remove the shell on macOS now. Could not find one single issue with the command call.

[CommandMC]

Alright, shell's removed now

With the last commit, I believe I've also fixed a bug: When you had an environment variable defined in both your process's env (so for example in .bashrc) and in Heroic's Settings, the process one would override Heroic's settings. That's now the other way around, which I think makes more sense

[flavioislima]

Looks good! 👍🏽

[flavioislima]

Alright, shell's removed now

With the last commit, I believe I've also fixed a bug: When you had an environment variable defined in both your process's env (so for example in .bashrc) and in Heroic's Settings, the process one would override Heroic's settings. That's now the other way around, which I think makes more sense

yes, exactly, the latest override the first inside an object.