Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOG] Cloud Saves support #1396

Merged
merged 10 commits into from
Jul 15, 2022

Conversation

imLinguin
Copy link
Member

@imLinguin imLinguin commented May 28, 2022

This PR is also some sort of refactor of cloud saves.
Notes:

  • Save paths now use environment variables, thus allowing for better compatibility in case wine changes things there
  • runWineCommand will default to runinprefix verb by default
  • Obtaining save path is based on winepath command
  • Syncing saves is using gogdl

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:wip WIP, don't merge. label May 28, 2022
@flavioislima flavioislima changed the base branch from main to beta May 31, 2022 15:46
@imLinguin imLinguin added pr:testing This PR is in testing, don't merge. and removed pr:wip WIP, don't merge. labels Jun 5, 2022
@imLinguin
Copy link
Member Author

I believe we are now in testing phase, there are some exceptions in case of finding games that support Cloud Saves feature. Case I know for sure is Cyberpunk 2077. It's a critical inaccuracy, before we merge this we need to find another way of checking if feature is supported.

@imLinguin imLinguin marked this pull request as ready for review July 6, 2022 13:12
@imLinguin imLinguin added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels Jul 7, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left just a few comments.
would be also nice to add the text with a warning that this feature is in Beta (for both epic and gog) and to backup the saves before using it. ⚔️

electron/gog/library.ts Show resolved Hide resolved
src/helpers/index.ts Outdated Show resolved Hide resolved
src/helpers/index.ts Show resolved Hide resolved
src/screens/Game/GamePage/index.tsx Outdated Show resolved Hide resolved
@flavioislima flavioislima added the pr:ready-to-merge This PR is fully ready for merge. label Jul 15, 2022
@imLinguin imLinguin merged commit ce70907 into Heroic-Games-Launcher:beta Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants