Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Check for CX bottle existence before launching a game #1399

Merged
merged 1 commit into from
May 29, 2022
Merged

[macOS] Check for CX bottle existence before launching a game #1399

merged 1 commit into from
May 29, 2022

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented May 28, 2022 •
edited

We had a lot of people that didn't realize that they actually had to create the CX bottle themselves. With this, a message is now displayed when the bottle doesn't exist, and the game launch is aborted

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC changed the title Check for CX bottle existance before launching a game Check for CX bottle existence before launching a game May 28, 2022
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 29, 2022
flavioislima
flavioislima approved these changes May 29, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏽

@flavioislima flavioislima added pr:ready-to-merge This PR is fully ready for merge. and removed pr:ready-for-review Feature-complete, ready for the grind! :P labels May 29, 2022
@flavioislima flavioislima changed the title Check for CX bottle existence before launching a game [macOS] Check for CX bottle existence before launching a game May 29, 2022
@CommandMC CommandMC merged commit 4c16d45 into Heroic-Games-Launcher:main May 29, 2022
@CommandMC CommandMC deleted the cx-bottle-detection branch May 29, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CommandMC @flavioislima