Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow game cards to grow to use the complete available horizontal space #1482

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jun 15, 2022

This PR fixes a small visual issue with the game grid leaving some empty space on the right side when wrapping into the next line. Now game cards can grow a bit to use all the space that's available when needed.

Before:
image

After:
image

Note that I also moved the logos for for images with logos so the title overlay doesn't cover it

I also added some extra padding at the bottom because the back to top button was overlapping the last element of the grid.

Before:
image

After: (now we can scroll a bit more)
image

This Fixes #1436


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jun 15, 2022
@arielj arielj linked an issue Jun 17, 2022 that may be closed by this pull request
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, pretty good approach to the size of the cards! 👍🏽

@arielj arielj merged commit f4b21e9 into beta Jul 7, 2022
@arielj arielj deleted the fixes/library-width branch July 7, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back to top button overlaps install button of last game card
2 participants