-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Add anticheat information when possible #1504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Left just some small comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides what Flavio found, looks good to me. We can actually implement tests for the backend functions. But maybe in another pr.
Just an idea: Maybe a new logprefix Anticheat
?
It might be good to include informations like the reference link notes and updates from the JSON file if present. |
I tried, but the information varies between games and it was really difficult to consider all the cases in a consistent design (you have games with multiple updates with different references, the main reference may not even match the last update reference so I can't use the main reference always without the updates) and without making it overwhelming. It felt like too much information, the average user might not care about all the details. I did add the link to open areweanticheatyet to see those details for the people that do want to know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I am curious to collect info on that from the next beta because some things might match and some others might not. But if we are not impending the user from installing the game then its fine.
Currently, the Reference is mostly used for games where there is official word from the developers or there have not been more than 1 changes to the status in the past (Mostly the reference is also the most straight to the point). Updates is what's used for the most recent additions and contains more precise information than the reference link, if I were to show any information in Heroic I'd go for the latest update. However the reference links are sometimes not really in sync with the updates at all, I will try to improve that and keep things more consistent |
Alright, I've update the list.
|
Co-authored-by: Felipe Santos <felipecassiors@gmail.com>
I updated this to use the namespace and to show a link to the latest reference for a given status: @felipecrs can you test this again with these changes? Thanks you both @felipecrs and @Curve for the initiative and the quick addition of this info! |
I was going to add this but then I saw I only use this in one place and the string always says |
Hey, great to see this. Unfortunately, I don't have an environment to test it, I trust you. By the way, I think if you display: Source: AreWeAntiCheatYet I think it would look a little better. |
Thanks, I'll change that, I think it will also make translations easier |
No problem, always an honor ^^ |
…uncher into feature/anticheat-badge
This PR adds anticheat information when possible using the information from AreWeAntiCheatYet.com.
It downloads the games.json from https://github.com/Starz0r/AreWeAntiCheatYet/blob/master/games.json at boot in the background only on Linux, to keep the information up to date (it's less than 100kb).
I left this message
It may not work due to denied or broken anticheat support
on purpose without interpolation of the actual status to help translations (also, I don't know how to handle translations based on a variable).I went over all the games in the json and looked for them in the epic store to create the map of names for games that have differences but I might have missed something, we can always add more or update when needed.
Denied:
Supported:
Broken:
Denied in install modal:
Use the following Checklist if you have changed something on the Backend or Frontend: