Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General] Add launcherArgs to native games again #1520

Merged
merged 1 commit into from
Jun 24, 2022
Merged

[General] Add launcherArgs to native games again #1520

merged 1 commit into from
Jun 24, 2022

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented Jun 23, 2022 •
edited

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label Jun 23, 2022
@CommandMC CommandMC requested a review from Nocccer June 23, 2022 14:27
@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels Jun 23, 2022
@Nocccer Nocccer changed the title Add launcherArgs to native games again [General] Add launcherArgs to native games again Jun 23, 2022
Nocccer
Nocccer approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked back. LGTM

@CommandMC CommandMC merged commit 14a7cd3 into main Jun 24, 2022
@CommandMC CommandMC deleted the fix/launchArgs branch June 24, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nocccer Nocccer Nocccer approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CommandMC @Nocccer