[Steam-Deck] Always maximize Heroic if Steam-Deck gamemode

[CommandMC]

This checks the XDG_CURRENT_DESKTOP=gamescope environment variable to detect if Heroic is running in Steam-Deck gamemode and starts Heroic in fullscreen.

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[CommandMC]

One thing that needs further testing is if we really have access to /run/host/etc/os-release in Flatpak. I was able to access it just fine on my machine, but it would be great if some more people could verify it

[CommandMC]

After further testing, we can indeed not access that file on Flatpak.
I'm not quite sure what I have to change to make it accessible either. @flavioislima could you help out here?

[CommandMC]

On another note, the code does work fine on AppImage. So it's really just that permission issue that's stopping this

[Nocccer]

2 small issues. One is from my eyes necessary. The other is just a way i would write the code.

[Nocccer]

I would go with a window-size command line option, instead detecting if we are on steam deck. This works for everyone everywhere.

[CommandMC]

That would be a good addition, but I'd say having a more automatic option like this is also good

[flavioislima]

Do you need to access /etc from the flatpak? That's not possible. I believe the only way this might work is by checking the kernel version, might be that Steam OS had something specific in the name. I'm not sure though.

[CommandMC]

Well, it's possible if we change the file access permissions. I just don't know which exact permission this is & where to change it

[flavioislima]

Well, it's possible if we change the file access permissions. I just don't know which exact permission this is & where to change it

Wdym? Which file?
Flatpaks cannot see the /etc folder even if we give access to the host system. It's a blacklisted directory:
https://docs.flatpak.org/en/latest/sandbox-permissions.html

[CommandMC]

Yes, but if we give it access, we can see it at /run/host/etc. I know this because the application that originally implemented this Steam Deck check is also distributed via Flatpak

Not quite sure where this is set, but --filesystem=/etc:ro should be enough to get the file to show up

[CommandMC]

Hm, actually, it seems like there's just a /run/host/os-release file. Let me check if that's normal or if I screwed something up

[CommandMC]

Looks like it's normal (search for os-release here). TIL

[flavioislima]

Looks like it's normal (search for os-release here). TIL

So maybe add the permission specifically to this file with full path.

[CommandMC]

You don't need a permission to access that file, as far as I can tell
At least I just reset my permissions locally and it's still there + it's there on a clean install (on a testing VM)

To check for yourself:

flatpak run --command=bash com.heroicgameslauncher.hgl
cat /run/host/os-release

[JakobDev]

It looks like /run/host/os-release is not available on older Flatpak versions, so make sure Heroic doesn't crash if it is not available.

[Nocccer]

We don't need to check if we are on steam deck. What we need todo is see if process.env.inGameMode or what it is called is true. If so we set the windows resolution to the monitor resolution. You can get monitor resolution via electron. I will write a example later.

This will also start heroic in full screen for holoiso users or if someone hooked up a external monitor with a higher resolution

Maybe this idea works also for bigpicturemode

[Nocccer]

I adapt @CommandMC solution and just maximize heroic if we run heroic from steam.
What do you think about that solution? Should we add a option to disable this behavior, if wanted?

[CommandMC]

Had some ideas on how to clean this up
I really like just checking for just Steam instead of the Deck, not sure why I wanted to limit it to that

[Nocccer]

Had some ideas on how to clean this up
I really like just checking for just Steam instead of the Deck, not sure why I wanted to limit it to that

Yes good changes.

[Nocccer]

LGTM. I would still consider a option to disable/enable this behavior. Waht do you think ?

[Nocccer]

I tested the appiamge on steam deck. It's working.

[CommandMC]

Well, can't approve since it's my PR as far as GitHub is concerned, but looks good!

[flavioislima]

LGTM!