Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] add optional '--no-https' flag for legendary args for LanCache compatibility #1538

Merged

Conversation

Keksgesicht
Copy link
Contributor

fixes issue #1032
Epic Games uses also only http for downloads.
This flag is default disabled, can be enabled via the advanced settings and gets applied to the uses of legendary commands "install", "update" and "repair".
New settings option has translations for english and german. Other languages are missing.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Keksgesicht Keksgesicht changed the title add optional '--no-https' flag for legedary args for LanCache compatibility add optional '--no-https' flag for legendary args for LanCache compatibility Jun 29, 2022
@Nocccer Nocccer changed the base branch from main to beta June 29, 2022 14:28
@Nocccer Nocccer changed the title add optional '--no-https' flag for legendary args for LanCache compatibility [General] add optional '--no-https' flag for legendary args for LanCache compatibility Jun 29, 2022
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arielj
Copy link
Collaborator

arielj commented Jul 3, 2022

How did you add the changes in the translation files? check this https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Translations#how-to-add-new-translatable-strings

Currently languages other than english and german will show an empty string instead of english. You should only add the key and the fallback in the code and use yarn i18next to udpate the files. Then, to add the geman translation, you have to use weblate instead of the code directly.

electron/legendary/games.ts Outdated Show resolved Hide resolved
Jan B added 2 commits July 3, 2022 12:37
This flag can be enabled via the advanced settings and gets applied to the uses of legendary commands "install", "update" and "repair".
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽

@flavioislima
Copy link
Member

@Keksgesicht thanks for the contribution :)

@flavioislima flavioislima merged commit cbb2e47 into Heroic-Games-Launcher:beta Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants