-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic] Anticheat runtimes (EAC and BattlEye) #1560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the error evaluation, this is a clean code.
But the error handling is important, so need to reject the pr.
How you handle the errors is your choice. You can do it in the backend or in the frontend.
Btw you could also write backend tests. Downloading/unzipping etc. You can have a look at heroic-wine-downloader tests, how i simulate a url request, download etc.
Wasn't done with this yet, otherwise I would've marked it as ready for review I understand your concerns and will implement error handling in the new functions. As for tests, other than examples, do you have a piece of documentation or something I can look at, to make sure I'm doing it right? |
Ah sorry didn't saw the wip. Ok i will resolve all comments for now. |
Alright, error handling is now in place. Let me know what you think, I'll take a look at tests now then |
Since it doesn't *just* contain the data now
The stacktrace was, for some reason, showing the wrong lines, which was confusing to work with. I'd say its better to just hide it for now
Unrelated, but this removes `yarn.lock` changes from the diff generated by git, which could sometimes have huge changes when people mix-and-match `npm` and `yarn`
08fbdaf
to
9160839
Compare
There are still a lot of tests missing, although the functionality itself might be nice to have for a beta release |
It is now possible to manage and enable anticheat runtimes in the launcher
Current issues:
BattlEye runtime doesn't work, the Wine-GE patch for it seems to not apply. Not sure why, needs more testingNevermind, the runtime works, the only game I was testing with (The Cycle: Frontier) did not work correctly
Use the following Checklist if you have changed something on the Backend or Frontend: