Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Not Checking games update on all platforms on refresh #1566

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Jul 12, 2022

Small fix that will check all games updates instead of only one platform when clicking the refresh button and on startup.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima changed the base branch from main to beta July 12, 2022 16:19
@CommandMC
Copy link
Collaborator

Hm, maybe, instead of always ignoring the runner, we could refresh both libraries when on "All", and only the respective runner when on "Epic"/"Gog"

@flavioislima
Copy link
Member Author

Hm, maybe, instead of always ignoring the runner, we could refresh both libraries when on "All", and only the respective runner when on "Epic"/"Gog"

I just don't see a use case for that now since the libraries are unified. But ok, will do the change 👍🏽

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 13, 2022
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, when someone is filtering the library to only display Epic games, and then presses refresh, it should also only refresh their Epic games.
At least I'd imagine that's what the user expects

@flavioislima
Copy link
Member Author

IMO, when someone is filtering the library to only display Epic games, and then presses refresh, it should also only refresh their Epic games. At least I'd imagine that's what the user expects

Yes, you are right, I am not looking to the right place here. I just need to fix the list of updatable games we keep on the storage. That's the issue, don't need to touch the refreshLibrary method.

@flavioislima
Copy link
Member Author

@CommandMC now I kept the old behavior and just fixed the list of games that were overridden when using a filter.

@flavioislima flavioislima merged commit 9a308ba into beta Jul 15, 2022
@flavioislima flavioislima deleted the fix/games_updates branch July 15, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants