Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Prompt for Visual C++ Runtime installation when not found #1583

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

CommandMC
Copy link
Collaborator

On Startup, we now check if the 64- and 32-bit-versions of the Visual C++ Runtime are installed and display a message if they aren't. These runtimes are required for a few games (Fall Guys for example), but they're expected to already be installed (I think the EGL installs them when it's installed?)

Some remarks:

  • The way I'm checking for the runtimes can probably have false positives (for example if someone has the actual development environment installed), although I don't think that's too big of an issue since you should still be fine if you have more than just the runtimes
  • The messages in the dialog boxes could be improved a bit (which is why I didn't run yarn i18next yet)
  • Displaying the message on each launch might be a little annoying, although I'd say the runtimes are important enough that everyone should have them installed

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 17, 2022
@CommandMC CommandMC self-assigned this Jul 17, 2022
@flavioislima flavioislima merged commit 78143a3 into beta Jul 17, 2022
@flavioislima flavioislima deleted the feat/vcruntime branch July 17, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants