Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Extract runtimes properly #1589

Merged
merged 1 commit into from
Jul 17, 2022
Merged

[Fix] Extract runtimes properly #1589

merged 1 commit into from
Jul 17, 2022

Conversation

CommandMC
Copy link
Collaborator

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label Jul 17, 2022
@CommandMC CommandMC requested a review from Nocccer July 17, 2022 16:14
@CommandMC CommandMC self-assigned this Jul 17, 2022
@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels Jul 17, 2022
Nocccer
Nocccer approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should wait for @flavioislima, because he frooze the beta branch?

flavioislima
flavioislima approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏽

@flavioislima flavioislima merged commit af17c54 into beta Jul 17, 2022
@flavioislima flavioislima deleted the fix/runtime-extraction branch July 17, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@Nocccer Nocccer Nocccer approved these changes

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CommandMC @flavioislima @Nocccer