Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Logger #1667

Merged
merged 33 commits into from Sep 13, 2022
Merged

[Refactor] Logger #1667

merged 33 commits into from Sep 13, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Aug 5, 2022 •
edited

Refactored logger

  • Able to pass objects, arrrays, numbers without making them a string to log functions ( logError, logInfo, ... )
  • Make paramters a option interface
  • Split logger and logfile functionality
  • Wrote tests for logger and logfile functions

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

CommandMC and others added 18 commits July 26, 2022 04:05
@CommandMC
Change complete project structure
8274b94 
 - Rename "src" -> "src/frontend"
 - Rename "electron" -> "src/backend"
 - Move types.ts to "common/types.ts"
@CommandMC
Switch from react-scripts + foreman + webpack + ts-loader -> Vite
25775ee
@CommandMC
Set GH_TOKEN and GITHUB_TOKEN in tests directly
763ac97 
This just cleans up package.json a bit
@CommandMC
Merge branch 'beta' into feat/vite
1257174
@CommandMC
Merge branch 'beta' into feat/vite
bb1f3d9
@CommandMC
Get SVG & JPG importing working in VSCode
54875e4
@CommandMC
Merge branch 'beta' into feat/vite
24a4ff8
@CommandMC
Move type definitions into common/typedefs
22903b1
@CommandMC
Fixup tests
9e2e73f
@CommandMC
Rewrite large chunks of the backend to be compatible with strict mode
2d7f54b
@CommandMC
Modify frontend to reflect changes to type definition structure
95b574d
@CommandMC
Remove unused files
caef5c8 
These weren't necessary, at least as far as I can tell
@CommandMC
Merge branch 'beta' into feat/vite
fe993b4
@CommandMC
Merge branch 'beta' into feat/vite
4cc2ee5
@CommandMC
Update translations
15ea70c
@Nocccer
Mapped logger refactor on vite pr
3979be5
@Nocccer
More clean up
87e6de0
@Nocccer
Fixed tests and added more lint rules
76509fc
@Nocccer Nocccer added the pr:wip WIP, don't merge. label Aug 5, 2022
@Nocccer Nocccer removed the pr:wip WIP, don't merge. label Aug 30, 2022
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 30, 2022
CommandMC
CommandMC reviewed Sep 10, 2022
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very close to being perfect, just got some questions/suggestions/ideas

src/backend/gog/setup.ts Outdated Show resolved Hide resolved
src/backend/logger/__tests__/logfile.test.ts Outdated Show resolved Hide resolved
src/backend/logger/__tests__/logfile.test.ts Show resolved Hide resolved
src/backend/logger/__tests__/logfile.test.ts Outdated Show resolved Hide resolved
src/backend/logger/__tests__/logfile.test.ts Outdated Show resolved Hide resolved
src/backend/logger/logger.ts Outdated Show resolved Hide resolved
src/backend/logger/logger.ts Outdated Show resolved Hide resolved
src/backend/logger/logger.ts Outdated Show resolved Hide resolved
src/backend/main.ts Outdated Show resolved Hide resolved
src/backend/utils.ts Show resolved Hide resolved
@Nocccer Nocccer merged commit 2667bc3 into beta Sep 13, 2022
@Nocccer Nocccer deleted the refactor/logger2 branch September 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommandMC CommandMC CommandMC approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima

@arielj arielj Awaiting requested review from arielj

@imLinguin imLinguin Awaiting requested review from imLinguin

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nocccer @CommandMC