[Tech] Enable sandboxing for ipcRenderer Processes

src/backend/api/library.ts

@@ -1,26 +1,18 @@
 import { ipcRenderer } from 'electron'
-import { Runner, InstallPlatform, LaunchParams } from '../../common/types'
+import { Runner, InstallParams, LaunchParams } from '../../common/types'
 
 export const removeFolder = (args: [path: string, folderName: string]) =>
   ipcRenderer.send('removeFolder', args)
 
 export const openDialog = async (args: Electron.OpenDialogOptions) =>
   ipcRenderer.invoke('openDialog', args)
-interface InstallArgs {
-  appName: string
-  path: string
-  installDlcs: boolean
-  sdlList: string[]
-  installLanguage?: string
-  runner: Runner
-  platformToInstall?: InstallPlatform
-}
-export const install = async (args: InstallArgs) =>
+
+export const install = async (args: InstallParams) =>
   ipcRenderer.invoke('install', args)
 export const openMessageBox = async (args: Electron.MessageBoxOptions) =>
   ipcRenderer.invoke('openMessageBox', args)
 export const uninstall = async (
-  args: [appName: string, checkboxChecked: boolean, runner: Runner]
+  args: [appName: string, shouldRemovePrefix: boolean, runner: Runner]
 ) => ipcRenderer.invoke('uninstall', args)
 export const repair = async (appName: string, runner: Runner) =>
   ipcRenderer.invoke('repair', appName, runner)
@@ -38,8 +30,16 @@ export const importGame = async (args: ImportGameArgs) =>
   ipcRenderer.invoke('importGame', args)
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-export const handleSetGameStatus = (callback: any) =>
+export const handleSetGameStatus = (callback: any) => {
   ipcRenderer.on('setGameStatus', callback)
+  return () => {
+    ipcRenderer.removeListener('setGameStatus', callback)
+  }
+}
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+// export const setGameStatusRemoveListener = (onGameStatusUpdate: any) => {
+//   ipcRenderer.removeListener('setGameStatus', onGameStatusUpdate)
+// }
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export const handleProgressOf = (version: string, callback: any) =>
   ipcRenderer.on('progressOf' + version, callback)

src/backend/api/misc.ts

@@ -78,9 +78,6 @@ export const getAnticheatInfo = async (namespace: string) =>
 
 export const requestSettingsRemoveListeners = () =>
   ipcRenderer.removeAllListeners('requestSettings')
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export const setGameStatusRemoveListener = (onGameStatusUpdate: any) =>
-  ipcRenderer.removeListener('setGameStatus', onGameStatusUpdate)
 
 export const clipboardReadText = async () =>
   ipcRenderer.invoke('clipboardReadText')

src/backend/gog/library.ts

@@ -138,16 +138,16 @@ export class GOGLibrary {
       return
     }
     this.refreshInstalled()
+    for (const game of libraryStore.get('games', []) as GameInfo[]) {
+      const copyObject = { ...game }
+      if (this.installedGames.has(game.app_name)) {
+        copyObject.install = this.installedGames.get(game.app_name)!
+        copyObject.is_installed = true
+      }
+      this.library.set(game.app_name, copyObject)
+    }
 
     if (!isOnline()) {
-      for (const game of libraryStore.get('games', []) as GameInfo[]) {
-        const copyObject = { ...game }
-        if (this.installedGames.has(game.app_name)) {
-          copyObject.install = this.installedGames.get(game.app_name)!
-          copyObject.is_installed = true
-        }
-        this.library.set(game.app_name, copyObject)
-      }
       return
     }
 

src/backend/main.ts

@@ -23,7 +23,8 @@ import {
   ipcMain,
   powerSaveBlocker,
   protocol,
-  screen
+  screen,
+  clipboard
 } from 'electron'
 import './updater'
 import { autoUpdater } from 'electron-updater'
@@ -118,7 +119,6 @@ import { gameInfoStore } from './legendary/electronStores'
 import { getFonts } from 'font-list'
 import { verifyWinePrefix } from './launcher'
 import shlex from 'shlex'
-import { clipboard } from 'electron'
 
 const { showMessageBox, showOpenDialog } = dialog
 const isWindows = platform() === 'win32'

src/frontend/components/UI/Sidebar/components/SidebarLinks/index.tsx

@@ -15,11 +15,6 @@ import classNames from 'classnames'
 import React, { useContext, useEffect, useState } from 'react'
 import { useTranslation } from 'react-i18next'
 import { faDiscord, faPatreon } from '@fortawesome/free-brands-svg-icons'
-import {
-  faCoffee,
-  faUserAlt,
-  faWineGlass
-} from '@fortawesome/free-solid-svg-icons'
 import { openDiscordLink, getGameInfo } from 'frontend/helpers'
 
 import ContextProvider from 'frontend/state/ContextProvider'

src/frontend/helpers/library.ts

@@ -141,7 +141,8 @@ async function install({
       path: `${path}`,
       installDlcs,
       sdlList,
-      runner
+      runner,
+      platformToInstall
     })
     .finally(() => {
       if (progress.percent === 100) {

src/frontend/hooks/hasProgress.ts

@@ -42,10 +42,11 @@ export const hasProgress = (appName: string) => {
         })
       }
     }
-    window.api.handleSetGameStatus(onGameStatusUpdate)
+    const setGameStatusRemoveListener =
+      window.api.handleSetGameStatus(onGameStatusUpdate)
 
     return () => {
-      window.api.setGameStatusRemoveListener(onGameStatusUpdate)
+      setGameStatusRemoveListener()
     }
   }, [])
 

src/frontend/index.tsx

@@ -14,7 +14,7 @@ import { initShortcuts } from './helpers/shortcuts'
 import { configStore } from './helpers/electronStores'
 
 window.addEventListener('error', (ev: ErrorEvent) => {
-  window.api.logError(ev.error.stack)
+  window.api.logError(ev.error)
 })
 
 const Backend = new HttpApi(null, {

src/frontend/screens/Game/GamePage/index.tsx

@@ -12,8 +12,7 @@ import {
   sendKill,
   size,
   syncSaves,
-  updateGame,
-  ipcRenderer
+  updateGame
 } from 'frontend/helpers'
 import { Link, NavLink, useParams } from 'react-router-dom'
 import { useTranslation } from 'react-i18next'

src/frontend/screens/Game/GameSubMenu/index.tsx

@@ -5,12 +5,7 @@ import React, { useContext, useEffect, useState } from 'react'
 import { AppSettings, GameStatus, Runner } from 'common/types'
 
 import { SmallInfo } from 'frontend/components/UI'
-import {
-  createNewWindow,
-  getGameInfo,
-  repair,
-  ipcRenderer
-} from 'frontend/helpers'
+import { createNewWindow, getGameInfo, repair } from 'frontend/helpers'
 import { useTranslation } from 'react-i18next'
 import ContextProvider from 'frontend/state/ContextProvider'
 import { uninstall } from 'frontend/helpers/library'

src/frontend/screens/Library/components/InstallModal/index.tsx

@@ -31,8 +31,7 @@ import {
   getProgress,
   install,
   size,
-  writeConfig,
-  ipcRenderer
+  writeConfig
 } from 'frontend/helpers'
 import ContextProvider from 'frontend/state/ContextProvider'
 import {

src/frontend/screens/Library/components/RecentlyPlayed/index.tsx

@@ -32,10 +32,11 @@ export default function RecentlyPlayed({ handleModal, onlyInstalled }: Props) {
   }
 
   useEffect(() => {
-    window.api.handleSetGameStatus(onGameStatusUpdates)
+    const setGameStatusRemoveListener =
+      window.api.handleSetGameStatus(onGameStatusUpdates)
 
     return () => {
-      window.api.setGameStatusRemoveListener(onGameStatusUpdates)
+      setGameStatusRemoveListener()
     }
   })
 

src/frontend/screens/Library/index.tsx

@@ -235,8 +235,8 @@ export default function Library(): JSX.Element {
     const notInstalled = library.filter(
       (g) => !g.is_installed && !installing.includes(g.app_name)
     )
-    const installingGames = library.filter((g) =>
-      installing.includes(g.app_name)
+    const installingGames = library.filter(
+      (g) => !g.is_installed && installing.includes(g.app_name)
     )
     library = sortInstalled
       ? [...installed, ...installingGames, ...notInstalled]

src/frontend/screens/Settings/components/AdvancedSettings/index.tsx

@@ -277,6 +277,7 @@ export const AdvancedSettings = ({
     const storage: Storage = window.localStorage
     storage.removeItem('updates')
     return window.api.clearCache()
+    return refreshLibrary({ fullRefresh: true, runInBackground: true })
   }
 
   return (

src/frontend/screens/Settings/components/LogSettings/index.tsx

@@ -71,7 +71,11 @@ export default function LogSettings({ isDefault, appName }: LogSettingsProps) {
 
   const getLogContent = () => {
     window.api
-      .getLogContent({ isDefault, appName, defaultLast })
+      .getLogContent({
+        isDefault,
+        appName: isDefault ? '' : appName,
+        defaultLast
+      })
       .then((content: string) => {
         setLogFileContent(content)
         setLogFileExist(true)
@@ -98,7 +102,11 @@ export default function LogSettings({ isDefault, appName }: LogSettingsProps) {
   }, [isDefault, defaultLast])
 
   function showLogFileInFolder() {
-    window.api.showLogFileInFolder({ isDefault, appName })
+    window.api.showLogFileInFolder({
+      isDefault,
+      appName: isDefault ? '' : appName,
+      defaultLast
+    })
   }
 
   return (

src/frontend/screens/Settings/components/OtherSettings/index.tsx

@@ -15,10 +15,9 @@ import CreateNewFolder from '@mui/icons-material/CreateNewFolder'
 import { EnviromentVariable, WrapperVariable, Runner } from 'common/types'
 import { Path } from 'frontend/types'
 import Backspace from '@mui/icons-material/Backspace'
-import { getGameInfo, ipcRenderer } from 'frontend/helpers'
+import { getGameInfo } from 'frontend/helpers'
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
-import { faCircleInfo } from '@fortawesome/free-solid-svg-icons'
-import { faFolderOpen } from '@fortawesome/free-solid-svg-icons'
+import { faCircleInfo, faFolderOpen } from '@fortawesome/free-solid-svg-icons'
 import {
   ColumnProps,
   TableInput

src/frontend/state/GlobalState.tsx

@@ -8,7 +8,8 @@ import {
   InstalledInfo,
   RefreshOptions,
   Runner,
-  WineVersionInfo
+  WineVersionInfo,
+  UserInfo
 } from 'common/types'
 import { Category, LibraryTopSectionOptions } from 'frontend/types'
 import { TFunction, withTranslation } from 'react-i18next'
@@ -17,8 +18,7 @@ import {
   getPlatform,
   install,
   launch,
-  notify,
-  ipcRenderer
+  notify
 } from '../helpers'
 import { i18n, t } from 'i18next'
 
@@ -32,7 +32,6 @@ import {
   libraryStore,
   wineDownloaderInfoStore
 } from '../helpers/electronStores'
-import { UserInfo } from 'common/types'
 
 const storage: Storage = window.localStorage