Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Epic games fails to install #1791

Merged
merged 1 commit into from Sep 10, 2022
Merged

[Fix] Epic games fails to install #1791

merged 1 commit into from Sep 10, 2022

Conversation

CommandMC
Copy link
Collaborator

Now using latest version from this PR:
derrod/legendary#477

Closes #1789, closes #1790

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC
Update Legendary
0f8fbc2 
Now using latest version from this PR:
derrod/legendary#477
@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label Sep 8, 2022
@CommandMC CommandMC self-assigned this Sep 8, 2022
@flavioislima
Copy link
Member

Did you chmod +x both Linux and mac binaries?

@jacobrakestraw
Copy link

You are a good man commandmc

@CommandMC
Copy link
Collaborator Author

Did you chmod +x both Linux and mac binaries?

Yup

Nocccer
Nocccer approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels Sep 9, 2022
@flavioislima flavioislima changed the title Update Legendary to fix issues relating to fetching game manifests [Fix] Epic games fails to install Sep 10, 2022
@flavioislima flavioislima merged commit 7d5228b into main Sep 10, 2022
@flavioislima flavioislima deleted the fix/update-legendary branch September 10, 2022 08:36
@CommandMC CommandMC mentioned this pull request Sep 10, 2022
Closed
@Nocccer Nocccer restored the fix/update-legendary branch September 12, 2022 16:24
@Nocccer Nocccer deleted the fix/update-legendary branch September 12, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@Nocccer Nocccer Nocccer approved these changes

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Since the epic games hotfix installation of new games broken Can't Install games from EPIC
4 participants
@CommandMC @flavioislima @jacobrakestraw @Nocccer