Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] TypeError: Unexpected end of json #1806

Merged
merged 4 commits into from Sep 12, 2022
Merged

[Fix] TypeError: Unexpected end of json #1806

merged 4 commits into from Sep 12, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Sep 12, 2022 •
edited

We never checked if installed.json and assets.json exist. Passing an empty string to JSON.parse() will throw Unexpected end of JSON.

  • Added try/catch around reading of installed.json and assets.json.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

CommandMC
CommandMC approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how that happened

@Nocccer Nocccer changed the title [Fix] Double import of useEffect [Fix] TypeError: Unexpected end of json Sep 12, 2022
@Nocccer Nocccer linked an issue Sep 12, 2022 that may be closed by this pull request
[GOG] Cant install TES Redguard "Cannot get game info" #1672
Closed
@flavioislima
Copy link
Member

I wonder how that happened

Probably during the merge with main.
It was like 100 conflicts, thats why it is better to merge beta in main ASAP.

@Nocccer Nocccer merged commit 4a4a416 into beta Sep 12, 2022
@Nocccer Nocccer deleted the fix/type-error branch September 12, 2022 15:33
flavioislima added a commit that referenced this pull request Sep 13, 2022
@flavioislima @Nocccer
@weblate @OctopusET @PS-Professional @CommandMC @Keksgesicht
[Tech] Merge Beta Branch in Main (#1811)
a1ead7a 
* [Feat] Proper check if heroic can communicate with internet (#1677)

* Added ping to check internet connection

* removed console.log

* Make log of error more clear

* Remove ping package and just use ping cli command

* Return if one ping succeed

* [i18n] Updated Translations (#1728)

* Update translation files

Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/
Translation: Heroic Games Launcher/GamePage

* Update translation files

Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/
Translation: Heroic Games Launcher/GamePage

* Translated using Weblate (Czech)

Currently translated at 100.0% (358 of 358 strings)

Translated using Weblate (Czech)

Currently translated at 100.0% (358 of 358 strings)

Update translation files

Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Shimon <simonfarm0@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/cs/
Translation: Heroic Games Launcher/GamePage
Translation: Heroic Games Launcher/Globals

* Update translation files

Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/
Translation: Heroic Games Launcher/GamePage

* Translated using Weblate (Korean)

Currently translated at 100.0% (358 of 358 strings)

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Moon Sungjoon <sumoon@seoulsaram.org>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ko/
Translation: Heroic Games Launcher/Globals

* Update translation files

Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/
Translation: Heroic Games Launcher/GamePage

* Translated using Weblate (Russian)

Currently translated at 100.0% (358 of 358 strings)

Translated using Weblate (Russian)

Currently translated at 100.0% (358 of 358 strings)

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Sedative <tertre3@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ru/
Translation: Heroic Games Launcher/Globals

* Update translation files

Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/
Translation: Heroic Games Launcher/GamePage

* Translated using Weblate (Persian)

Currently translated at 100.0% (358 of 358 strings)

Update translation files

Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Parsa Shadab <shadab.balgori@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fa/
Translation: Heroic Games Launcher/GamePage
Translation: Heroic Games Launcher/Globals

* Update translation files

Updated by "Squash Git commits" hook in Weblate.

Translation: Heroic Games Launcher/Globals
Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/

Co-authored-by: Shimon <simonfarm0@gmail.com>
Co-authored-by: Moon Sungjoon <sumoon@seoulsaram.org>
Co-authored-by: Sedative <tertre3@gmail.com>
Co-authored-by: Parsa Shadab <shadab.balgori@gmail.com>

* Revert "[i18n] Updated Translations" (#1745)

Revert "[i18n] Updated Translations (#1728)"

This reverts commit 7f5d2b3.

* [Tech] Switch from react-scripts to Vite & clean up everything to work with strict mode (#1633)

* Change complete project structure

 - Rename "src" -> "src/frontend"
 - Rename "electron" -> "src/backend"
 - Move types.ts to "common/types.ts"

* Switch from react-scripts + foreman + webpack + ts-loader -> Vite

* Set GH_TOKEN and GITHUB_TOKEN in tests directly

This just cleans up package.json a bit

* Get SVG & JPG importing working in VSCode

* Move type definitions into common/typedefs

* Fixup tests

* Rewrite large chunks of the backend to be compatible with strict mode

* Modify frontend to reflect changes to type definition structure

* Remove unused files

These weren't necessary, at least as far as I can tell

* Update translations

* Fixup: Re-add `--filesystem` parameter for Proton

Turns out refactoring a lot of stuff can introduce issues, who would've
thought

* Remove `build` script

You never have to run this yourself, so it was a bit confusing to have.
If you really need its functionality, `vite build` isn't that hard to
type in on your own :^)

* Fully remove all remnants of UE support

* Add new 'codecheck' command

This command can be used to make sure that no files in the project
violate TS rules, since Vite itself doesn't check them

It would probably be a good idea to add them to GH Workflows and/or
pre-commit hooks, but I'm not too sure on how to do that

* Update translation files

* Fix translation files

Not sure how this happens, but it seems they've gotten screwed up
in the merge

* Remove some more unnecessary files

* Always get game updates from all libraries

This fixes an issue where refreshing the library while only showing
one library made the update icons of all the others disappear

* Some misc code style changes

* Merge branch 'main' of github.com:Heroic-Games-Launcher/HeroicGamesLauncher into beta

* [Fix] Check if Legendary's `metadata` folder exists before trying to read it (#1785)

* [Fix] Not permanently saving downloadNoHttps config option (#1797)

fixing not permanently saving downloadNoHttps config option

* Merge branch 'main' of github.com:Heroic-Games-Launcher/HeroicGamesLauncher into beta

* [Fix] TypeError: Unexpected end of json (#1806)

* remove useEffect double import

* catch type error end of json

* Added try catch

* Add log prefix to see what runner fails

* [Tech] Add codecheck to pre push and workflow (#1794)

* Add codecheck to pre push and workflow

* Add new workflow for codecheck

* renaming

* [Fix] Update legendary binaries (#1809)

Update legendary binaries

* fix: gog getGameinfo after clear the cache

Co-authored-by: Niklas <61798668+Nocccer@users.noreply.github.com>
Co-authored-by: Weblate (bot) <hosted@weblate.org>
Co-authored-by: Shimon <simonfarm0@gmail.com>
Co-authored-by: Moon Sungjoon <sumoon@seoulsaram.org>
Co-authored-by: Sedative <tertre3@gmail.com>
Co-authored-by: Parsa Shadab <shadab.balgori@gmail.com>
Co-authored-by: Mathis Dröge <34034631+CommandMC@users.noreply.github.com>
Co-authored-by: Jan B <32649612+Keksgesicht@users.noreply.github.com>
@Nocccer Nocccer linked an issue Sep 14, 2022 that may be closed by this pull request
[General UI/UX] Replace Native Dialogs with HTML Dialogs #1152
Closed
@Nocccer Nocccer removed a link to an issue Sep 14, 2022
[General UI/UX] Replace Native Dialogs with HTML Dialogs #1152
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GOG] Cant install TES Redguard "Cannot get game info"
3 participants
@Nocccer @flavioislima @CommandMC