Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/sidebar #1865

Merged
merged 2 commits into from Oct 24, 2022
Merged

Refactor/sidebar #1865

merged 2 commits into from Oct 24, 2022

Conversation

BrettCleary
Copy link
Collaborator

sidebar elements are now centered correctly.

before
image

after
image

Also applied some of the .button style to the button element. Applying other fields breaks some of the existing design.

Renamed some of the styles to match the style-xx naming convention.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really review this change as I have little CSS knowledge, but from the provided images & small bit of testing myself, seems to be alright 👍

@BrettCleary BrettCleary merged commit 4db52bd into beta Oct 24, 2022
@BrettCleary BrettCleary deleted the refactor/sidebar branch October 24, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants