Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] Move default save computation into the backend #1887

Merged
merged 29 commits into from
Nov 2, 2022
Merged

[TECH] Move default save computation into the backend #1887

merged 29 commits into from
Nov 2, 2022

Commits on Oct 8, 2022

  1. Update legendary to 0.20.29

    @CommandMC
    CommandMC committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    a01e9bc View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Misc: Minor IPC changes 

    The IPC call removed here did not actually do anything, since there's
never a listener for `requestSettings` created in the frontend
    @CommandMC
    CommandMC committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    40ae1c0 View commit details
    Browse the repository at this point in the history

  2. Add save_path to GameInfo 

    This is the save path computed by Legendary, only populated after
`sync-saves` was ran
    @CommandMC
    CommandMC committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    7441c6b View commit details
    Browse the repository at this point in the history

  3. [Epic] Move default save computation into the backend & rely on Legen… 

    …dary to compute it
    @CommandMC
    CommandMC committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    ec574de View commit details
    Browse the repository at this point in the history

  4. Fixup: Actually refresh game info after running sync-saves 

    Not sure why this issue didn't happen before, but the game info
wasn't actually being refreshed after we ran the `save-sync` command,
leading to, in theory, no `save_path` ever getting set. Again, no
idea how this worked before
    @CommandMC
    CommandMC committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    901258f View commit details
    Browse the repository at this point in the history

  5. Pass Wine env vars to Legendary

    @CommandMC
    CommandMC committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    6fd4765 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Move save computation into its own file

    @CommandMC
    CommandMC committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    80eb710 View commit details
    Browse the repository at this point in the history

  2. Extract getShellPath into its own function

    @CommandMC
    CommandMC committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a124647 View commit details
    Browse the repository at this point in the history

  3. Add a bunch of new GOG interfaces/types

    @CommandMC
    CommandMC committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    29422b9 View commit details
    Browse the repository at this point in the history

  4. Use the new types in GOGLibrary

    @CommandMC
    CommandMC committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    14c3c8d View commit details
    Browse the repository at this point in the history

  5. Move GOG save path computation into the backend

    @CommandMC
    CommandMC committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    1b35d93 View commit details
    Browse the repository at this point in the history

  6. Remove unused getRealPath IPC call

    @CommandMC
    CommandMC committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b689b4e View commit details
    Browse the repository at this point in the history

  7. Make sure the computed save folder exists before running realpath o… 

    …n it
    @CommandMC
    CommandMC committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    cbee1e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Make it possible to directly specify a ProtonVerb when running Prot… 

    …on commands
    @CommandMC
    CommandMC committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    2052417 View commit details
    Browse the repository at this point in the history

  2. Add new getWinePath function and use it in save_sync.ts 

    This will reliably return the path even if Proton is used
    @CommandMC
    CommandMC committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    9c6166a View commit details
    Browse the repository at this point in the history

  3. Add a whole bunch of debug logging

    @CommandMC
    CommandMC committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    b952e52 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'beta' into feat/dont-guess-save-path

    @CommandMC
    CommandMC committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    c84822d View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Merge branch 'beta' into feat/dont-guess-save-path

    @CommandMC
    CommandMC committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    95051a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Merge branch 'beta' into feat/dont-guess-save-path

    @CommandMC
    CommandMC committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    29916f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2022

  1. Fixup runWineCommand 

    This brings runWineCommand closer to how callRunner works for example.
The same `commandParts` idiom is used to make it possible to exactly
specify what the arguments are that should be passed to `wine`

In the process, I've also made the `wait` variable actually
work again (with spawn, we're no longer using a shell, so we have
to put in a little more work than adding `&& <extra_command>`
to run another command after the first one finishes)
    @CommandMC
    CommandMC committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    d9e5611 View commit details
    Browse the repository at this point in the history

  2. Update translation files

    @CommandMC
    CommandMC committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    9c33b5d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'beta' into feat/dont-guess-save-path

    @CommandMC
    CommandMC committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    ec51eaa View commit details
    Browse the repository at this point in the history

  4. Use callAbortController instead of killing the child process

    @CommandMC
    CommandMC committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    f1a2fe7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Run cmd /c echo path in getWinePath to expand Windows env vars

    @CommandMC
    CommandMC committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    7f048ca View commit details
    Browse the repository at this point in the history

  2. Just always run cmd /c winepath path 

    See Discord for notes as to why
Gotta love Proton weirdness
    @CommandMC
    CommandMC committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3f791a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Remove debug logging

    @CommandMC
    CommandMC committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c62f45a View commit details
    Browse the repository at this point in the history

  2. Make workingDir and arguments optional for FileTask

    @CommandMC
    CommandMC committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ef95e9a View commit details
    Browse the repository at this point in the history

  3. New 'other' TaskCategory

    @CommandMC
    CommandMC committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    df403c3 View commit details
    Browse the repository at this point in the history

  4. overlaySupported optional property of info file

    @CommandMC
    CommandMC committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    3789fd5 View commit details
    Browse the repository at this point in the history