Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Fixup: Show Wine Prefix in Game Settings again #1894

Merged
merged 1 commit into from Oct 13, 2022

Conversation

CommandMC
Copy link
Collaborator

After the settings refactor (#1726), I noticed that the "Wine Prefix" setting was missing from the game settings. Took a quick look at the code, this bit at the start of the WinePrefix component seems to be the issue


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 12, 2022
@CommandMC CommandMC requested a review from arielj October 12, 2022 14:28
@CommandMC CommandMC self-assigned this Oct 12, 2022
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@flavioislima flavioislima merged commit b297456 into beta Oct 13, 2022
@flavioislima flavioislima deleted the fix/wineprefix-settings branch October 13, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants