Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Make it possible to disable the React developer tools #1895

Merged
merged 2 commits into from Oct 14, 2022

Conversation

CommandMC
Copy link
Collaborator

This PR allows for disabling the installation of the React dev tools by setting the HEROIC_NO_REACT_DEVTOOLS env var before running yarn dev.

I'm currently developing on a somewhat older machine, and I've noticed that this leads to just a little bit faster load times. And that little time goes a long way when you're restarting Heroic ~50 times a day :^)


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 12, 2022
@CommandMC CommandMC self-assigned this Oct 12, 2022
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be good to update the README to show this next to the yarn dev instructions.

@flavioislima flavioislima requested review from a team, Nocccer, imLinguin and redromnon and removed request for a team October 14, 2022 09:36
@CommandMC CommandMC merged commit a8bca14 into beta Oct 14, 2022
@CommandMC CommandMC deleted the feat/toggleable-devtools branch October 14, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants