Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error if the select wine doesn't exist #1912

Merged
merged 5 commits into from Oct 17, 2022
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 15, 2022

This PR adds an error dialog when a user tries to do an action that requires Wine but the binary doesn't exist.

This is really common when deleting wine versions without updating the wine version of the game for example, and trying to run the game/winetricks/winecfg/exe on prefix were failing silently in the frontend or confusingly (winetricks dialog stuck doing nothing).

This would address #1906 and also show more info for the user to quickly address the problem without having to check the logs.

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team October 15, 2022 23:35
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 16, 2022
src/backend/launcher.ts Outdated Show resolved Hide resolved
src/backend/legendary/games.ts Show resolved Hide resolved
@arielj arielj merged commit 6626721 into beta Oct 17, 2022
@arielj arielj deleted the feature/warn-missing-wine branch October 17, 2022 03:02
@arielj arielj linked an issue Oct 22, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the Winetricks button if winetricks is not available
2 participants