Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux] Remove Resizable BAR toggle #1921

Merged
merged 1 commit into from Oct 19, 2022
Merged

[Linux] Remove Resizable BAR toggle #1921

merged 1 commit into from Oct 19, 2022

Conversation

CommandMC
Copy link
Collaborator

This was already on by default in VKD3D-Proton for over a year (so toggling the option did nothing at all)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC
Remove Resizable BAR toggle
8568571 
This was already on by default in VKD3D-Proton for over a year
(so toggling the option did nothing at all)
@CommandMC CommandMC self-assigned this Oct 17, 2022
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 17, 2022
@CommandMC CommandMC requested review from a team, arielj, flavioislima, Nocccer, imLinguin and redromnon and removed request for a team October 17, 2022 23:13
@arielj arielj mentioned this pull request Oct 19, 2022
Closed
arielj
arielj approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs that only remove code are so satisfying haha

flavioislima
flavioislima approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I wonder if we still need FSR options as well. It seems now it is on by default as well for Wine-GE and Proton. 🤔

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Oct 19, 2022 •
edited

Nice! I wonder if we still need FSR options as well. It seems now it is on by default as well for Wine-GE and Proton. thinking

It can still be disabled using the same env variable (as far as I can remember), so I guess it's only useful to disable it now. I'm not sure if that's enough to justify removing it

@CommandMC CommandMC merged commit bc79812 into beta Oct 19, 2022
@CommandMC CommandMC deleted the remove/rebar-setting branch October 19, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima flavioislima approved these changes

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CommandMC @Etaash-mathamsetty @arielj @flavioislima