Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using custom CSS files to theme Heroic #1939

Merged
merged 3 commits into from Oct 26, 2022
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 24, 2022

This PR add the feature of using custom CSS files as themes in Heroic.

I'll add some details about naming conventions and limitations here https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Custom-Themes in the next few days

How it works:

  • users can select a path to store their .css files
  • once set, the .css files will be listed in the theme selector
  • when a theme is selected, if it's not one of the defaults, a <style> tag is injected at the top of the body element with the content of the .css file
custom-themes.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 24, 2022
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team October 24, 2022 03:29
@arielj arielj added pr:wip WIP, don't merge. and removed pr:ready-for-review Feature-complete, ready for the grind! :P labels Oct 24, 2022
@arielj arielj added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:wip WIP, don't merge. labels Oct 24, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome, a really simple approach and works really well.
I think now we will need a website to share user themes, ahahaha.

@arielj arielj merged commit a3eb82b into beta Oct 26, 2022
@arielj arielj deleted the feature/custom-themes branch October 26, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants