Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add Nord Light and Dark theme #1941

Merged

Conversation

redromnon
Copy link
Collaborator

@redromnon redromnon commented Oct 25, 2022

This PR adds the Nord Theme, specifically two variants - Light and Dark.

Also added separate variables

  • --text-gametitle - Color of game's name on the game card
  • --text-log - Color of the yellow warning text above the game's log

Nord Light
heroic-nord-light

Nord Dark
heroic-nord-dark


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Add Nord Light Theme
  • Add Nord Dark Theme
  • Refactor Game's Title and Log text
  • Refactor common CSS attributes
  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@redromnon redromnon self-assigned this Oct 25, 2022
@redromnon redromnon marked this pull request as draft October 25, 2022 12:36
@redromnon
Copy link
Collaborator Author

@biliesilva Can you test this PR?

@biliesilva
Copy link

@biliesilva Can you test this PR?

Yes, I will finish some things that I'm doing and will test it :)

@biliesilva
Copy link

biliesilva commented Oct 25, 2022

Invert the color of these icons/menus from this:

image

to this and set the inactive to #748AA0
image

I think is better to select another color for these icons, because it doesn't contrast with the background. Maybe this color:
#5FA1B4

Also, this color doesn't contract well with the background. Could you make these changes:

  • Change the color of the links to #527AAA
  • Change the Play button and Installed color to #639F30
  • Change the settings buttons to #81A1C1

And this changes too:
image

image

@redromnon
Copy link
Collaborator Author

redromnon commented Oct 26, 2022

The thing is, I can't alter colors for most of the individual UI components easily. It would require a lot of refactoring.

For instance,

  • The icons/buttons of the library follow --accent/ #88c0d0 for active and --text-default/#2e3440 for inactive state [1st Screenshot]
  • The blue UI components of the game's settings page all follow the --accent theme which is #88c0d0
    [2nd Screenshot]
  • The same applies for the Accounts page where the language selection follows the input field color like the search bar #adb2ba, Go To Library follows the --accent and the account name fields follow the same --background/#d8dee9 and --text-default
    [3rd Screenshot]

The current implmentation of the code is ideal for dark themes. The Nord Dark theme should be very straightforward to implement.
I'll see what I can do.

@flavioislima
Copy link
Member

Yes, perhaps we need some variables that are specific to those action icons:
--action-icon, --action-icon-hover and --action-icon-active for instance.
I think we are overusing --accent right now, so would be good to split it.

@redromnon
Copy link
Collaborator Author

Maybe a separate PR can be created to address this and I can merge it into this PR.

@flavioislima flavioislima marked this pull request as ready for review October 27, 2022 20:10
@flavioislima
Copy link
Member

Changed this one to ready to review to generate the builds but I forgot that it does not generate when it has conflicts.

@redromnon redromnon added the pr:wip WIP, don't merge. label Oct 28, 2022
@redromnon
Copy link
Collaborator Author

Fixed the conflicts for now.

Yes, perhaps we need some variables that are specific to those action icons:
--action-icon, --action-icon-hover and --action-icon-active for instance.
I think we are overusing --accent right now, so would be good to split it.

Will look into this.

@redromnon
Copy link
Collaborator Author

How about this look?

new-nord-light-bg

background - #eceff4
input dialogs/search box - #d8dee9

Makes the text and icon colours look clearer.

@biliesilva
Copy link

How about this look?

new-nord-light-bg

background - #eceff4 input dialogs/search box - #d8dee9

Makes the text and icon colours look clearer.

Looks better! We can collect some feedback after release and make some adjustments if needed.

@redromnon redromnon added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:wip WIP, don't merge. labels Oct 30, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good stuff, they look amazing. Thanks for that! ⚔️

@flavioislima flavioislima merged commit 54ac7cc into Heroic-Games-Launcher:beta Nov 1, 2022
@redromnon redromnon deleted the feat-nord-light_dark branch November 1, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants