Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Duplicate kill listener #1944

Merged
merged 5 commits into from Oct 27, 2022
Merged

[Fix] Duplicate kill listener #1944

merged 5 commits into from Oct 27, 2022

Conversation

BrettCleary
Copy link
Collaborator

Removes the duplicate 'kill' handler added in from download manager PR which causes issues with other ipcMain handlers.

Also removed the pre-push test command and added os checks to certain tests that are only written for linux.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just added a comment but it's all good

@CommandMC
Copy link
Collaborator

The 2nd kill method is missing the extra functionality added by #1864. To resolve this, replace

return getGame(appName, runner).stop()

with

runner === 'sideload' ? stop(appName) : getGame(appName, runner).stop()

(import stop from ./sideload/games)

@Nocccer Nocccer changed the title Fix/duplicate kill [fix] Duplicate kill listener Oct 26, 2022
@Nocccer Nocccer changed the title [fix] Duplicate kill listener [Fix] Duplicate kill listener Oct 26, 2022
@Nocccer Nocccer self-requested a review October 26, 2022 23:09
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aggree with @CommandMC. There is something missing from the sideload app. Easy fix.

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested here and now Login is working again.
Thanks for fixing that.

@flavioislima flavioislima merged commit 369ff67 into beta Oct 27, 2022
@flavioislima flavioislima deleted the fix/duplicate_kill branch October 27, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants