New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Duplicate kill listener #1944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just added a comment but it's all good
The 2nd HeroicGamesLauncher/src/backend/main.ts Line 1329 in 1e01cb2
with runner === 'sideload' ? stop(appName) : getGame(appName, runner).stop() (import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aggree with @CommandMC. There is something missing from the sideload app. Easy fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested here and now Login is working again.
Thanks for fixing that.
Removes the duplicate 'kill' handler added in from download manager PR which causes issues with other ipcMain handlers.
Also removed the pre-push test command and added os checks to certain tests that are only written for linux.
Use the following Checklist if you have changed something on the Backend or Frontend: