Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues when uninstalling games #1950

Merged
merged 2 commits into from Oct 29, 2022
Merged

Fix some issues when uninstalling games #1950

merged 2 commits into from Oct 29, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 28, 2022

This PR fixes (and partially fixes) some issues I've noticed:

  • after uninstalling a game (but not a sideloaded app), the library status was not updated properly (it was a new but, no the one that was fixed haha)
  • in slow systems, since you confirm uninstalling a game until it actually gets uninstalled and the UI is updated you can still click the play button which will try to start the game and make everything act weird

This PR disabled the play buttons when uninstalling and shows more visual feedback with an uninstalling status label, both in the game card and in the game page.

There are still issues (you can click uninstall multiple times, and you can click any of the game tools/menu options while it's getting uninstalled, but I'll add a separated issue for that since I think it requires more discussions)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 28, 2022
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team October 28, 2022 03:28
@arielj arielj mentioned this pull request Oct 28, 2022
Closed
flavioislima
flavioislima approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 8bbe559 into beta Oct 29, 2022
@flavioislima flavioislima deleted the fixes/uninstalling branch October 29, 2022 18:12
wbrtm pushed a commit to wbrtm/HeroicGamesLauncher that referenced this pull request Oct 30, 2022
@arielj @wbrtm
[UI/UX] Fix some issues when uninstalling games (Heroic-Games-Launche…
47b1ebd 
…r#1950)

* Fix library status after uninstall, prevent some actions during unintall

* Update i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arielj @flavioislima