Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Refactor Action Icons #1952

Merged
merged 2 commits into from Oct 29, 2022
Merged

[UI] Refactor Action Icons #1952

merged 2 commits into from Oct 29, 2022

Conversation

redromnon
Copy link
Collaborator

@redromnon redromnon commented Oct 28, 2022 •
edited

Use separate variables for the action icons found in the library page.

action-icon1
action-icon2

  • Default : --action-icon
  • Hover : --action-icon-hover
  • Active : --action-icon-active

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@redromnon redromnon added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 28, 2022
flavioislima
flavioislima approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good. 👍🏽

@flavioislima flavioislima merged commit 08e176d into Heroic-Games-Launcher:beta Oct 29, 2022
@redromnon redromnon deleted the ui-refactor-action-icons branch October 30, 2022 03:02
wbrtm pushed a commit to wbrtm/HeroicGamesLauncher that referenced this pull request Oct 30, 2022
@redromnon @wbrtm
[UI] Refactor Action Icons (Heroic-Games-Launcher#1952)
2470887 
* Split action icon CSS variables

* Fix Dracula theme action-icon mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redromnon @flavioislima