Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize eslint settings #1953

Merged
merged 1 commit into from Oct 29, 2022
Merged

Optimize eslint settings #1953

merged 1 commit into from Oct 29, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 28, 2022

Using these settings can reduce the time required by eslint to check the project before pushing. On my case it went from 1 minute to less than 4 seconds (if we don't use the --cache option we still have a good benefit -from 1 minute to less than 10 seconds on my system-).


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 28, 2022
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team October 28, 2022 13:03
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@flavioislima flavioislima merged commit 7c30d0b into beta Oct 29, 2022
@flavioislima flavioislima deleted the optimiz-eslint-settings branch October 29, 2022 18:09
wbrtm pushed a commit to wbrtm/HeroicGamesLauncher that referenced this pull request Oct 30, 2022
cache eslint results, tsconfig only on /src
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants