Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/UX] Pre-release Fixes #1956

Merged
merged 9 commits into from Oct 29, 2022
Merged

[UI/UX] Pre-release Fixes #1956

merged 9 commits into from Oct 29, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Oct 29, 2022 •
edited

Just some Small Fixes:

  • Show the store filter only for logged-in stores
  • Don't show Platform filter on windows
  • Invert the Grid/List icon
  • Trigger refresh library when clicking on Got to Library and on the Sidebar Library button, since after being logged in the library was not refreshing properly and it was showing an empty list. This also makes it easier to show new games after getting then on the stores, since when clicking the library button the new game will appear right away.
  • Fix filters on the header not proper aligned.
  • Removed gawk from the list of dependencies since it is not needed for a long time now.
  • Added a request to the Bottle SteamGrid API to get the image for the sideloaded game. Mirko said I could use it for that.
  • Fix current download not showing in the sidebar after restarting heroic.
  • Fix BE error message when no log was found for a game.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima requested review from a team, arielj, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team October 29, 2022 19:37
flavioislima and others added 2 commits October 29, 2022 23:17
@flavioislima
fix: current download on sidebar after restart
0a045e9
@flavioislima @CommandMC
Fix README.md typo
a95dbbf 
Co-authored-by: Mathis Dröge <34034631+CommandMC@users.noreply.github.com>
arielj
arielj reviewed Oct 29, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@flavioislima flavioislima changed the title [UI/UX] Fix Header and Library refresh after Login [UI/UX] Pre-release Fixes Oct 29, 2022
This was linked to issues Oct 29, 2022
Skip login, show Library #1936
Closed
Login into a store changes the filter of the Library to only that store #1949
Closed
@flavioislima flavioislima merged commit d043008 into beta Oct 29, 2022
@flavioislima flavioislima deleted the fix/ui_fixes branch October 29, 2022 21:51
wbrtm pushed a commit to wbrtm/HeroicGamesLauncher that referenced this pull request Oct 30, 2022
@flavioislima @CommandMC @wbrtm
[UI/UX] Pre-release Fixes (Heroic-Games-Launcher#1956)
f0898eb 
* fix: header filters

* fix: action icons grid/list order

* fix: refresh library after login

* other: remove gawk from dependencies

* feat: get game img from bottles steamGrid api

* fix: current download on sidebar after restart

* Fix README.md typo

Co-authored-by: Mathis Dröge <34034631+CommandMC@users.noreply.github.com>

* fix: log not found error

* fix: typo and lint

Co-authored-by: Mathis Dröge <34034631+CommandMC@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj left review comments

@CommandMC CommandMC CommandMC approved these changes

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login into a store changes the filter of the Library to only that store Skip login, show Library
3 participants
@flavioislima @arielj @CommandMC