Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] context menu selection/hovering #1961

Merged
merged 2 commits into from Nov 2, 2022

Conversation

wbrtm
Copy link
Contributor

@wbrtm wbrtm commented Oct 30, 2022

This is an incomplete fix to issue #1908
It fixes the issue most of the times. It does not always work for games near/at the bottom of the window/screen, where the context menu is rendered on top of the clicked item (GameCard or install button) triggering the hover effect (darker color).

Another idea is to disable the hover effect entirely when using the keyboard/gamepad navigation, not sure how to go about that though.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@wbrtm wbrtm marked this pull request as ready for review October 30, 2022 15:52
@wbrtm
Copy link
Contributor Author

wbrtm commented Oct 31, 2022

Latest commit fixes the issue for all game cards. If the offset was only introduced for aesthetic reasons we should be fine. It still remains for list items near the bottom of the window/screen.

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good now, thanks for fixing that.

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@arielj arielj merged commit d2a4066 into Heroic-Games-Launcher:beta Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants