Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 2.5.0 Stable fixes #2107

Merged
merged 39 commits into from
Dec 5, 2022
Merged

[Fix] 2.5.0 Stable fixes #2107

merged 39 commits into from
Dec 5, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Nov 30, 2022 •
edited

This should fix the errors below.

Fixes

  • Fix the issue with the download's progress going nuts
  • Fix a crash on the Install dialog on some games
  • Fix sideload games not being added to steam automatically.
  • Fix Games failing to start when launched from Steam because they have an update
  • Fix games falling to start when launched from Steam when they had Sync Saves but the path was not defined
  • Fix Auto detect saves path going on forever. Now it will have a timeout of 15s.
  • [Linux/macOS] Fix the windows version of a game version being recognized as native and not showing Wine settings and others.
  • Fix a crash that was happening when uninstalling Sideloaded Apps
  • Fix Login Page container size max Width
  • Possibly fix the state of the game card not correctly updating. Not showing an update button, for instance.
  • [Windows] Fix an issue where Heroic was crashing when opening the install dialog.
  • Heroic will clean the cache now after upgrading to a new release since some issues are associated with that after updating.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima requested review from a team, arielj, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team November 30, 2022 09:22
@flavioislima flavioislima changed the title [Fix] Cannot install some GOG games due to languages not found error [Fix] Cannot install some GOG games due to languages being undefined Nov 30, 2022
@flavioislima

This comment was marked as outdated.

Sign in to view
@flavioislima flavioislima linked an issue Nov 30, 2022 that may be closed by this pull request
Cannot use 'in' operator to search for 'languages' in null #2104
Closed
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 30, 2022
@flavioislima flavioislima changed the title [Fix] Cannot install some GOG games due to languages being undefined [Fix] 2.5.0 Stable fixes Nov 30, 2022
@flavioislima flavioislima linked an issue Nov 30, 2022 that may be closed by this pull request
Cannot install Roller Coaster Tycoon (GOG) #2112
Closed
@flavioislima flavioislima mentioned this pull request Dec 1, 2022
Closed
@lever1209 lever1209 mentioned this pull request Dec 4, 2022
Closed
@lever1209
Copy link

@flavioislima it may be something i did wrong when merging this pr in my local repo, but the install screen seems to freeze up completely when getting the download and install sizes for paradigm
image

arielj
arielj reviewed Dec 4, 2022
View reviewed changes
src/backend/gog/games.ts Outdated Show resolved Hide resolved
@flavioislima
Copy link
Member Author

@flavioislima it may be something i did wrong when merging this pr in my local repo, but the install screen seems to freeze up completely when getting the download and install sizes for paradigm
image

I believe I forgot to update the gogdl binaries with this proper fix on this pr, will do it tomorrow.

@flavioislima flavioislima mentioned this pull request Dec 5, 2022
Closed
@flavioislima
Copy link
Member Author

@lever1209 updated the binaries, should work now.

@lever1209
Copy link

lever1209 commented Dec 5, 2022 •
edited

@flavioislima its working well now

but it seems to freeze on 100% downloaded, ill test that its not just my weird laptop its just my weird laptop

CommandMC
CommandMC reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we really have to take care of our @ts-expect-error problems soon, a lot of this PR is fixing an issue that can't really be "seen" by Typescript

src/backend/gog/games.ts Outdated Show resolved Hide resolved
src/backend/legendary/library.ts Outdated Show resolved Hide resolved
src/frontend/components/UI/Sidebar/components/SidebarLinks/index.tsx Outdated Show resolved Hide resolved
@flavioislima flavioislima merged commit 2a5c030 into main Dec 5, 2022
@flavioislima flavioislima deleted the fix/lang_err_gog branch December 5, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommandMC CommandMC CommandMC approved these changes

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

@arielj arielj Awaiting requested review from arielj

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
4 participants
@flavioislima @lever1209 @arielj @CommandMC