-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/macOS] Add Wine and DXVK support for macOS #2108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
added
pr:wip
WIP, don't merge.
pr:testing
This PR is in testing, don't merge.
labels
Dec 1, 2022
flavioislima
added
pr:ready-for-review
Feature-complete, ready for the grind! :P
and removed
pr:wip
WIP, don't merge.
pr:testing
This PR is in testing, don't merge.
labels
Dec 1, 2022
flavioislima
requested review from
arielj,
CommandMC,
Nocccer,
BrettCleary and
redromnon
December 1, 2022 14:31
@Heroic-Games-Launcher/development |
CommandMC
reviewed
Dec 5, 2022
CommandMC
reviewed
Dec 6, 2022
CommandMC
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Wine and Wineskin support to macOS.
Although, packaged applications cannot access system wine so versions like Wine-Crossover should be installed on the user applications folder so we know in case someone asks why it is not being detected. So if it is installed using BREW it needs to be moved to the user Applications folder.
Wineskin doesn't matter since Heroic will use the Wrapper inside ~/Applications/Wineskin.
Not sure if we should support the whole wrapper/prefix/bottle for WineSkin, will need to check the effort for that.
Besides that, DXVK toggle is now enabled for Wine version type on Mac and feedback was added to when it is being installed because, so the settings will be disabled and the text will change.
Ofc the DXVK methods to get latest version and install were also changed since they differ from the Linux version.
Use the following Checklist if you have changed something on the Backend or Frontend: