Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Library] Disable Play button while launching game #2120

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 2, 2022

This is a workaround for #2115

There are two changes:

  • added a new isLaunching state in the card component to be able to disable the button while we wait for the game to start (we should detect that it's doing a save sync and show that in the UI)
  • only do sync saves if the user enables the option instead

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 2, 2022
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team December 2, 2022 02:22
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for fixing that.

@arielj arielj merged commit dd164e6 into main Dec 2, 2022
@arielj arielj deleted the disable-play-button branch December 2, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants