Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Save sync for native games #2137

Merged
merged 4 commits into from
Dec 6, 2022
Merged

[Fix] Save sync for native games #2137

merged 4 commits into from
Dec 6, 2022

Conversation

CommandMC
Copy link
Collaborator

  • No longer verifyWinePrefix if the game is native
  • No longer pass setupWineEnvVars(...) to Legendary if the game is native
  • Store correct default save folder on Mac

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC
Attempt to fix save sync for native games
3cee58c
@CommandMC
Fall back to correct folder on Mac
c06290f 
This also includes some type touchups, so we can more easily detect if a
game supports save sync

The `as never`s introduced here
are correspondence problems
@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label Dec 4, 2022
@CommandMC CommandMC self-assigned this Dec 4, 2022
@flavioislima
Copy link
Member

Tested here on macOS and it is getting the correct folder.
Will check on Windows.

@CommandMC CommandMC changed the title Try to fix save sync for native games [Fix] Save sync for native games Dec 5, 2022
@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels Dec 5, 2022
flavioislima
flavioislima approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 06e70fc into main Dec 6, 2022
@flavioislima flavioislima deleted the fix/savesync-native branch December 6, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CommandMC @flavioislima