Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/UX] Added warning dialog for external links #2227

Merged
merged 3 commits into from
Dec 28, 2022
Merged

[UI/UX] Added warning dialog for external links #2227

merged 3 commits into from
Dec 28, 2022

Conversation

Mark12870
Copy link
Contributor

@Mark12870 Mark12870 commented Dec 18, 2022 •
edited

Added dialog with warning, while user click on external link in menu.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Mark12870 Mark12870 changed the title Added warning dialog for external links (#2178) Added warning dialog for external links Dec 18, 2022
@flavioislima
Copy link
Member

Thanks for that. The code looks good, will do some testing soon.
I can see you also added new translations, can you open a PR with the new keys (after running yarn i18n) on the locales repository?
This is the link:
https://github.com/Heroic-Games-Launcher/locales/pulls

@flavioislima flavioislima added pr:testing This PR is in testing, don't merge. pr:ready-for-review Feature-complete, ready for the grind! :P labels Dec 20, 2022
@flavioislima flavioislima self-requested a review December 20, 2022 21:24
@Mark12870
Copy link
Contributor Author

Thanks for that. The code looks good, will do some testing soon. I can see you also added new translations, can you open a PR with the new keys (after running yarn i18n) on the locales repository? This is the link: https://github.com/Heroic-Games-Launcher/locales/pulls

I have no idea how to open the PR in different project. :/ Or maybe I misunderstood something.

@flavioislima flavioislima changed the title Added warning dialog for external links [UI/UX] Added warning dialog for external links Dec 28, 2022
flavioislima
flavioislima approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here and looks cool!
Thanks for that! 👍🏽

@flavioislima flavioislima changed the base branch from main to stable December 28, 2022 15:55
@flavioislima flavioislima changed the base branch from stable to main December 28, 2022 15:57
@flavioislima flavioislima merged commit 2aa80f6 into Heroic-Games-Launcher:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj

@redromnon redromnon Awaiting requested review from redromnon

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P pr:testing This PR is in testing, don't merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mark12870 @flavioislima