Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Electron, Chrome and NodeJS versions #2377

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Log Electron, Chrome and NodeJS versions #2377

merged 2 commits into from
Feb 1, 2023

Conversation

Root-Core
Copy link
Contributor

Implements #1194

Tested it on Manjaro Linux + AppImage

@Nocccer Nocccer requested review from a team, arielj, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team January 31, 2023 17:38
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 31, 2023
@Nocccer
Copy link
Collaborator

Nocccer commented Jan 31, 2023

Please run yarn prettier-fix and push to make the lint workflow pass

flavioislima
flavioislima approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit dd07b05 into Heroic-Games-Launcher:main Feb 1, 2023
@Root-Core Root-Core deleted the patch-1 branch February 3, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Root-Core @Nocccer @flavioislima