Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Add file:// to the preload protocol for login #2532

Merged
merged 1 commit into from Mar 18, 2023
Merged

[EPIC] Add file:// to the preload protocol for login #2532

merged 1 commit into from Mar 18, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Mar 10, 2023

This fixes this issue I get when running the app from source:
image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 10, 2023
Etaash-mathamsetty
Etaash-mathamsetty approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

flavioislima
flavioislima approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my mistake 😅

@arielj
Copy link
Collaborator Author

arielj commented Mar 18, 2023

I tested the generated app image from this build and the login works fine in a build too 👍 merging it

@arielj arielj merged commit 4978c6c into main Mar 18, 2023
@arielj arielj deleted the add-preload-protocol branch March 18, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@Nocccer Nocccer Nocccer approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arielj @flavioislima @Etaash-mathamsetty @Nocccer