[Tech] Refactor Game Managers #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init * refactor gog, legendary, hyperplay games.ts * update submodule to latest main commits * refactor game manager games module * update types, refactor library manager * fix diskWrite merge * fix more types * rm bin exec override * move store managers into storeManagers folder * fix data types for hp games, add listUpdateableGames * refactor library refresh * refactor runWineCommand and hasGame * rm hasUpdate, fix hp store install version * rm refreshInstalled from library interface * rm unused updateAllGames * fix stop, add unzipping status, add inject process name * change unzipping to extracting, add process names, fix restricted char bugs * fix legendary and gog download status * fix gog install, uninstall * fix default install path setting * fix proton/wine * fix gog and legendary import * update gameInfo and use gameInfo to inject HP Games * move storeManager maps and fxns out of main * fix legendary moveInstall and changeInstallPath * refresh gog when app is ready * fix changeGameInstallPath * fix uninstall when gog game is already moved * fix remaining merge conflicts * add one conditional method call
…uncher into tech/refactor_game_managers
flavioislima
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Thats a lot of stuff but in general looks good.
Tested basically everything on a new install and current install and everything seems to work just fine.
I think this approach is fine and finally, we are moving out of OOP and all boilerplate it was bringing to the code.
Thanks for that
|
I am merging this one to avoid more conflicts in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the legendary, gog, and sideload store managers into a consistent module level interface.
This reduces complexity and decouples the store managers from code that consumes it through abstraction and allows for further extensibility of game managers to other stores in the future.
This also removes the overly complex object oriented singleton approach which only serves to remove the need to pass appName to each function. A module level functional approach is simpler, easier to test, and accomplishes the same objectives of code reuse and consistent interface.
Sideload Game info has been added into GameInfo which makes sense because the frontend shouldn't be concerned with implementation level backend details like what store/runner the game is using
Fixes a bug with the default install path setting
Fixes a bug where successive downloads would remain queued and not install
Tested on Windows
(Launch Proton tested on SteamDeck)
Epic Games
GOG
Sideload
Further Work
Refactor
gog/user.tsandlegendary/user.tsto use the same module level functional typeFix electron module mocking for tests
Use the following Checklist if you have changed something on the Backend or Frontend: