New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add DLCs manager for Epic Games #2734
Conversation
src/frontend/screens/Library/components/InstallModal/DownloadDialog/DLCDownloadListing.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathis Dröge <mathis.droege@ewe.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing installing the alien game with its only DLC and there's no indication in the downloads that it includes the DLC
I think it's because since it's all the DLCs it has and it's just passing the --with-dlcs
flag then it's not adding the DLCs as extra downloads which makes sense to me but maybe we can add a (with all DLCs)
after the name in these cases?
like: Alien: Isolation (with all DLCs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one issue I noticed is that it's installing all DLCs if none is selected
I tried installing The Messenger without picking the picnic
DLC and the install command has the --with-dlcs
and then the when I open the DLCs dialog it shows as installed
another issue I noticed (but this one shouldn't be a blocker) is that you can click a DLC in the completed list in the download manager and it takes you to the specific DLC's details page instead of the parent's page for example, I installed the messenger DLC individually so I have the I think we should redirect to the DLC's parent if the game we are opening the GamePage is actually a DLC to avoid issue (I think many of the three dots menu options will fail or do weird stuff for DLCs -like moving the game-) I think it's not a blocker (can be handled outside this PR) but would be nice if it's easy to fix |
@ariel, those issues with the messenger and alien isolation are for Epic games? GOG we still pass the flag but for epic games, we won't. In my tests here, Dying Light Enhanced edition, for instance, has 2 DLCs, if I select All DLCs it adds the 2 to the queue as expected. But for GOG games, it will pass the flag to install all. EDIT: Ok, I think I forgot to remove the flag from the legendary install command. Will push a fix to it. |
…oicGamesLauncher into feat/epic_dlcs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! all my comments are addressed and the feature works correctly for me 👍
I tested installing and uninstalling games on both gog windows/linux and epic, installing with and without DLCs for Epic and installing/uninstalling DLCs for epic after a game is installed
This PR adds the ability to:
Use the following Checklist if you have changed something on the Backend or Frontend: