Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add DLCs manager for Epic Games #2734

Merged
merged 23 commits into from May 29, 2023
Merged

[Feat] Add DLCs manager for Epic Games #2734

merged 23 commits into from May 29, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented May 27, 2023

This PR adds the ability to:

  • Select individual DLCs to be installed for Epic games, instead of installing all or nothing.
  • Adds a new item on the Game Page SubMenu to open a DLC manager dialog where is possible to install and uninstall available DLCs.
  • Works only for Epic for now, GOG keeps the current behavior until GogDL adds this feature as well.
  • When selecting the DLCs on the install dialog, they will be added to the download Queue just after the main game.
image image

image

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 27, 2023
Co-authored-by: Mathis Dröge <mathis.droege@ewe.net>
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing installing the alien game with its only DLC and there's no indication in the downloads that it includes the DLC

image

I think it's because since it's all the DLCs it has and it's just passing the --with-dlcs flag then it's not adding the DLCs as extra downloads which makes sense to me but maybe we can add a (with all DLCs) after the name in these cases?

like: Alien: Isolation (with all DLCs)

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one issue I noticed is that it's installing all DLCs if none is selected

I tried installing The Messenger without picking the picnic DLC and the install command has the --with-dlcs and then the when I open the DLCs dialog it shows as installed

@arielj
Copy link
Collaborator

arielj commented May 27, 2023

another issue I noticed (but this one shouldn't be a blocker) is that you can click a DLC in the completed list in the download manager and it takes you to the specific DLC's details page instead of the parent's page

for example, I installed the messenger DLC individually so I have the picnic panick entry in the download manager, I click that and it takes me to the picnic panic game details page but its play button doesn't work, then I go back and launch the base the messenger game and it works ootb

I think we should redirect to the DLC's parent if the game we are opening the GamePage is actually a DLC to avoid issue (I think many of the three dots menu options will fail or do weird stuff for DLCs -like moving the game-)

I think it's not a blocker (can be handled outside this PR) but would be nice if it's easy to fix

@flavioislima
Copy link
Member Author

flavioislima commented May 28, 2023

@ariel, those issues with the messenger and alien isolation are for Epic games? GOG we still pass the flag but for epic games, we won't. In my tests here, Dying Light Enhanced edition, for instance, has 2 DLCs, if I select All DLCs it adds the 2 to the queue as expected.

But for GOG games, it will pass the flag to install all.

EDIT: Ok, I think I forgot to remove the flag from the legendary install command. Will push a fix to it.

@flavioislima
Copy link
Member Author

another issue I noticed (but this one shouldn't be a blocker) is that you can click a DLC in the completed list in the download manager and it takes you to the specific DLC's details page instead of the parent's page

for example, I installed the messenger DLC individually so I have the picnic panick entry in the download manager, I click that and it takes me to the picnic panic game details page but its play button doesn't work, then I go back and launch the base the messenger game and it works ootb

I think we should redirect to the DLC's parent if the game we are opening the GamePage is actually a DLC to avoid issue (I think many of the three dots menu options will fail or do weird stuff for DLCs -like moving the game-)

I think it's not a blocker (can be handled outside this PR) but would be nice if it's easy to fix

For now I will disable the click on DLCs and also remove the action icons:
image

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! all my comments are addressed and the feature works correctly for me 👍

I tested installing and uninstalling games on both gog windows/linux and epic, installing with and without DLCs for Epic and installing/uninstalling DLCs for epic after a game is installed

@flavioislima flavioislima merged commit 0ae766a into main May 29, 2023
13 checks passed
@flavioislima flavioislima deleted the feat/epic_dlcs branch May 29, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants