Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getGameInfo and prefix when uninstalling #2808

Merged
merged 1 commit into from Jun 21, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jun 19, 2023

I started fixing the uninstall dialog but it actually fixes two issues:

  • the uninstall dialog was failing to get the correct getGameInfo (the installedGames variable was not properly initialized) and then it was also skipping the set of the prefix for non-native games (so it was not showing the prefix to uninstall)
  • when fixing the getGameInfo api function, this also fixed that issue when sometimes the GamePage component would show a game as NOT installed when the game is actually installed and displayed just fine in the library

@flavioislima I'm not sure why the if (!isNative || isDLC) check there included the native value so it would be great if you can review that, I don't know why that was there in the first place.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jun 19, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team June 19, 2023 23:02
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima
Copy link
Member

@flavioislima I'm not sure why the if (!isNative || isDLC) check there included the native value so it would be great if you can review that, I don't know why that was there in the first place.

I also do not remember to be honest. I may have introduced there by mistake or was testing something when I was implementing the DLCs manager and forgot to revert.

@arielj arielj merged commit 6303f40 into main Jun 21, 2023
13 checks passed
@arielj arielj deleted the fix-incorrect-game-info-and-uninstall branch June 21, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants