Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Fetch steam deck comaptibility #2829

Merged
merged 12 commits into from Jul 14, 2023
Merged

[Feature]: Fetch steam deck comaptibility #2829

merged 12 commits into from Jul 14, 2023

Conversation

kohend
Copy link
Contributor

@kohend kohend commented Jun 30, 2023 •
edited by Nocccer

Fetch steamdeck and protondb compatibiltiy and show it on game page.

image
image
image
image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer changed the title Get steam deck comaptibility [Feature]: Fetch steam deck comaptibility Jul 1, 2023
@Nocccer Nocccer requested review from a team, arielj, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 1, 2023 02:14
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 1, 2023
Nocccer
Nocccer approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Left some opinion but nothing that holds back this feature.

src/common/types.ts Show resolved Hide resolved
@kohend
Copy link
Contributor Author

kohend commented Jul 1, 2023

image

Nocccer
Nocccer requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the frontend implementation. Something is wrong here.
Maybe not your fault but i would make a new component like HowLonToBeat and Gamescore.
The component combines apple crossover compatiblity and proton/steamdeck compatibility.
If you don't know how, i could do that.

src/backend/wiki_game_info/wiki_game_info.ts Outdated Show resolved Hide resolved
@Nocccer Nocccer self-requested a review July 4, 2023 19:34
@Nocccer
Copy link
Collaborator

Nocccer commented Jul 4, 2023 •
edited

@arielj @flavioislima Can you look over the frontend implementation?
Code in the backend is already reviewed and tested.

kohend
kohend commented Jul 5, 2023
View reviewed changes
Copy link
Contributor Author

@kohend kohend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better than what I did, well, I'm not a UI person

src/frontend/screens/Game/GamePage/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/Game/GamePage/index.tsx Outdated Show resolved Hide resolved
src/backend/wiki_game_info/wiki_game_info.ts Outdated Show resolved Hide resolved
flavioislima
flavioislima approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think looks good using the icons on the UI 👍🏽

@flavioislima flavioislima merged commit d56f232 into Heroic-Games-Launcher:main Jul 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kohend @Nocccer @flavioislima