Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOG]: fix obtaning manifest for updates check #2882

Merged
merged 3 commits into from
Jul 23, 2023
Merged

[GOG]: fix obtaning manifest for updates check #2882

merged 3 commits into from
Jul 23, 2023

Conversation

imLinguin
Copy link
Member

Due to recent CDN issues, this change switches to updated _version=2 API, which provides fallback CDNs.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 22, 2023
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC and Nocccer and removed request for a team July 22, 2023 14:20
arielj
arielj approved these changes Jul 23, 2023
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine for me, I left a comment about the types but shouldn't be a blocker anyway

@arielj arielj added this to the 2.9 milestone Jul 23, 2023
@imLinguin imLinguin linked an issue Jul 23, 2023 that may be closed by this pull request
Every game on gog is in constant "update available" #2885
Closed
@imLinguin
compare etags locally too
bce3b35 
also added early return for playtime sync to avoid confusion when it logs that it successfully synced
flavioislima
flavioislima approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 188bfab into main Jul 23, 2023
13 checks passed
@flavioislima flavioislima deleted the fix/gog_manifest_obtaining branch July 23, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

Every game on gog is in constant "update available"
3 participants
@imLinguin @arielj @flavioislima