Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Specify --wrapper only if there are wrappers #2893

Merged
merged 1 commit into from Jul 25, 2023
Merged

[Fix] Specify --wrapper only if there are wrappers #2893

merged 1 commit into from Jul 25, 2023

Conversation

CommandMC
Copy link
Collaborator

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 24, 2023
@CommandMC CommandMC requested a review from a team July 24, 2023 23:08
@CommandMC CommandMC self-assigned this Jul 24, 2023
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer and imLinguin and removed request for a team July 24, 2023 23:08
@arielj arielj mentioned this pull request Jul 25, 2023
Closed
@Nocccer
Copy link
Collaborator

Nocccer commented Jul 25, 2023

I will merge this, so i can check if i can write a test for this bug.

@Nocccer Nocccer merged commit 5212c78 into main Jul 25, 2023
13 checks passed
@Nocccer Nocccer deleted the fix/wrapper branch July 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

@imLinguin imLinguin imLinguin approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CommandMC @Nocccer @arielj @imLinguin