Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Browser]: handle before unload event properly #2939

Merged
merged 2 commits into from Aug 9, 2023
Merged

[Browser]: handle before unload event properly #2939

merged 2 commits into from Aug 9, 2023

Conversation

imLinguin
Copy link
Member

Closes #2938
Heroic will now confirm if you want to close the window if website prevents the unload

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:testing This PR is in testing, don't merge. label Jul 30, 2023
volkayno
volkayno approved these changes Jul 30, 2023
View reviewed changes
Copy link

@volkayno volkayno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as intended, fixing #2938

flavioislima
flavioislima approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imLinguin imLinguin added pr:ready-to-merge This PR is fully ready for merge. and removed pr:testing This PR is in testing, don't merge. labels Jul 30, 2023
@arielj arielj added this to the 2.9.2 milestone Jul 30, 2023
@flavioislima flavioislima merged commit f11ecef into main Aug 9, 2023
13 checks passed
@flavioislima flavioislima deleted the before_unload_handler branch August 9, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC CommandMC approved these changes

@volkayno volkayno volkayno approved these changes

Assignees
No one assigned
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

MadWorldMMO/Browser game can't be closed
5 participants
@imLinguin @flavioislima @CommandMC @volkayno @arielj